Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: changed "Twitter" to "𝕏 (Twitter)" in README.md #581

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

BandhiyaHardik
Copy link
Contributor

changed Twitter's old name to new one 𝕏

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?
changed "Twitter" to "𝕏 (Twitter)" in README.md
Can it be referenced to an Issue? If so what is the issue # ?
#580
How can we test it?

Summary

Does this PR introduce a breaking change?

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser

Other information

changed Twitter's old name to new one 𝕏
@kalwalt
Copy link
Member

kalwalt commented Nov 2, 2023

Hi @BandhiyaHardik thank you for you PR. Generally we require pull requests pointing to the dev branch, but because it will cause any issue maybe we can merge as it is, what do you think @nickw1 ?

@kalwalt kalwalt added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 2, 2023
@kalwalt kalwalt self-assigned this Nov 2, 2023
@BandhiyaHardik
Copy link
Contributor Author

Hi @BandhiyaHardik thank you for you PR. Generally we require pull requests pointing to the dev branch, but because it will cause any issue maybe we can merge as it is, what do you think @nickw1 ?

@kalwalt From next time i will keep this in mind and make sure i open my PR in dev branch in this repository.

@kalwalt kalwalt merged commit e2f2893 into AR-js-org:master Nov 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
2 participants