Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: testing Python 3.11 #931

Merged
merged 1 commit into from
Aug 10, 2023
Merged

ci: testing Python 3.11 #931

merged 1 commit into from
Aug 10, 2023

Conversation

ErikBjare
Copy link
Member

No description provided.

@ErikBjare
Copy link
Member Author

ErikBjare commented Aug 3, 2023

CI passing. Would need some real-life testing, and ensurance that 3.11 is widely adopted.

3.9 has EOL on 05 Oct 2025
3.10 has EOL on 04 Oct 2026
3.11 has EOL on 24 Oct 2027

3.10 brings nice stuff like X | Y union syntax
3.11 brings ~10-25% performance improvement (also this is kinda nice: https://github.com/asottile/pyupgrade#use-datetimeutc-alias)

Releases are supported for 5 years after their release.
3.11 has now been out for 9 months.

I kinda don't want to wait for 3.9 to become EOL. We're now ~halfway into its life-cycle.

@BelKed
Copy link
Contributor

BelKed commented Aug 6, 2023

What exactly you mean by "real-life testing" and "ensurance that 3.11 is widely adopted"?


By the way, Python 3.11 seems to work fine for me :)


Also, aren't we shipping a prebuilt binary, so Python version shouldn't matter?

@ErikBjare
Copy link
Member Author

What exactly you mean by "real-life testing" and "ensurance that 3.11 is widely adopted"?

Just that the PyInstaller-built executables actually run on real machines (and not just in CI), and that any contributors won't have to jump through hoops to get Python 3.11 (but should be fine).

Will merge this for now, hoping it doesn't break anything, and will later eventually remove support for Python 3.9 & 3.10 in the underlying modules.

@ErikBjare
Copy link
Member Author

ErikBjare commented Aug 29, 2023

Turns out PyInstaller-built executables do not run correctly on Windows: #936

I'll probably go through build/CI changes since v0.12.6 and restore Python 3.9 for now.

Edit: made a PR downgrading Python to 3.9 #941

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants