Make all bindings compiled bindings #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiled bindings helps a ton with trimming compatibility which is required for native aot. Currently, to make nativeaot work, you need to add messagebox.Avalonia in your root descriptors. This has worked for me, but when I inspected why I needed to do this, I found that all the bindings of this lib were on reflection and I when I tried to convert them to compiled, I only saw problems with the tags properties on buttons.
However, looking further into it with dev tools, I found they were not resolving to anything so they had null. This implies that the way they were bound was already not really doing anything useful.
Being surprised at how easy it was to switch over to compiled bindings, I submit this pr to simply do it. It can avoid having messagebox.avalonia getting trimmed out without manual interventions. I also couldn't see any breakage in the test project.