Added DracthyrAlliance & DracthyrHorde Dragonflight character races. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will need some help implementing the DBC for TrinityCore master branch 10.1.0.50000 in the near future. |
BAndysc
reviewed
Jul 8, 2023
| @@ -44,5 +46,6 @@ public enum CharacterRaces : uint | |||
| AllWoD = AllMoP, | |||
| AllLegion = AllWoD | Nightborne | HighmountainTauren | VoidElf | LightforgedDraenei, | |||
| AllBfA = AllLegion | ZandalariTroll | KulTiran | DarkIronDwarf | Vulpera | MagharOrc | Mechagnome, | |||
| AllShadowlands = AllBfA | |||
There was a problem hiding this comment.
Could you also add new races to AllAlliance/AllHorde enum?
There was a problem hiding this comment.
Could you also add new faces to AllAlliance/AllHorde enum?
Talk to me on Discord as I have a question regarding this matter. I have given you my Discord ID in a comment below.
|
Good job, one small comment added, feel free to text me on discord for help regarding dbc reading! |
I couldn't find your Discord ID anywhere. Here's mine. SheikhHash#7594 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.