Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check zero buffer update, reformat pipeline layout, parallel shader loading #8099

Merged
merged 4 commits into from
May 5, 2020

Conversation

ottoville
Copy link
Contributor

@ottoville ottoville commented May 2, 2020

  • Fix unnecessary mapped buffer on buffer creation in certain cases
  • Do not kill tab in chrome if updating buffer with 0 size data
  • Use getBindGroupLayout to create a layout if necessary.
  • Load fragment shader while vertex shader is being processing.
@ottoville ottoville changed the title check zero buffer update, reformat pipeline layout May 2, 2020
src/Engines/webgpuEngine.ts Outdated Show resolved Hide resolved
src/Engines/webgpuEngine.ts Outdated Show resolved Hide resolved
src/Materials/effect.ts Outdated Show resolved Hide resolved
@ottoville
Copy link
Contributor Author

ottoville commented May 5, 2020

I restored the _getPipelineLayout method into engine but also modified the _getBindGroupsToRender method to create a layout with getBindGroupLayout if layout has not been created.
The functionality has been described here gpuweb/gpuweb#446
This will make _getPipelineLayout method totally unnecessary, it can be deleted and still engine works. I did not delete it as I dont know how this will affect on performance.

@ottoville ottoville requested a review from sebavan May 5, 2020 11:43
@sebavan
Copy link
Member

sebavan commented May 5, 2020

Love it !!! yup do not delete for now but will do in a bit I guess :-)

@sebavan sebavan merged commit fbd1e68 into BabylonJS:WebGPU May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants