Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate proper extensionsUsed/Required declarations #7

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Jan 24, 2023

The current state generated the following for tilesets that used extensions:

{
  "asset": {
    "version": "1.0"
  },
  "extensions": {
    "extensionsRequired": [
      "3DTILES_draco_point_compression"
    ],
    "extensionsUsed": [
      "3DTILES_draco_point_compression"
    ]
  },
  "extensionsRequired": [
    "3DTILES_draco_point_compression"
  ],
  "geometricError": 17.32,
...

For a moment I was stumped by the validator message "The extension 'extensionsUsed' was used, but is not supported" (and considered a bug in the validator), but that's indeed what's in the input...

This PR fixes these declarations.

NOTE: There are some unknowns about this repository on my side. Despite occasional fixes, it's unfortunately not guaranteed that the generated output matches the current CesiumJS spec data 1:1. Any differences can probably only be analyzed and resolved iteratively - like with this PR.

@lilleyse lilleyse merged commit 2f79f88 into CesiumGS:main Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants