Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to GitHub actions #11527

Merged
merged 10 commits into from
Oct 25, 2023
Merged

Migrate from Travis CI to GitHub actions #11527

merged 10 commits into from
Oct 25, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Sep 19, 2023

We're looking to move from Travis CI to GitHub Actions to match the rest of the Cesium organization.

While there's a lot of awesome features in GitHub Actions we can start taking advantage of to automate more of or processes, this initial PR migrates the existing Travis CI functionality. That includes:

  • Linting
  • Running tests
  • Verifying npm packages
  • Building and deploying to S3
  • Running coverage and deploying results to S3
  • Setting the status to include links to both of the above deployments
  • A specialized deployment when pushing to the cesium.com branch
  • Slack notifications on a failed commit on main or cesium.com branches
@ggetz ggetz requested a review from jjhembd September 19, 2023 20:10
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
@ggetz ggetz marked this pull request as ready for review September 19, 2023 20:10
@mramato
Copy link
Contributor

mramato commented Oct 24, 2023

@ggetz If you search for travis there are still a ton of references, mostly doc but a few in .gitignore and build.js (and even a few code comments).

It's probably worth doing a pass to clean these up as well. If you think it makes sense to do them as a follow-up PR instead, that's fine too. Let me know.

@mramato
Copy link
Contributor

mramato commented Oct 24, 2023

The deployment link in the PR status 404s: http://cesium-dev.s3-website-us-east-1.amazonaws.com/cesium/github-actions/

All other artifacts seem to work though.

@mramato
Copy link
Contributor

mramato commented Oct 24, 2023

That's all I have for this go around @ggetz

@ggetz
Copy link
Contributor Author

ggetz commented Oct 24, 2023

Thanks for the review @mramato!

The deployment link in the PR status 404s

This was due to the 30-day cleanup in s3 since we skip re-uploading existing files. We disabled this behavior for the main branch so that the files would be "touched" each CI run for the sake of this cleanup rule. Since it's showing up here as well, I've gone ahead and disabled it for development branches as well.

If you search for travis there are still a ton of references, mostly doc but a few in .gitignore and build.js (and even a few code comments).

I've gone ahead and replaced these in this PR, as well as updating the contributor documentation.

@mramato
Copy link
Contributor

mramato commented Oct 25, 2023

Thanks, @ggetz I pushed one last tweak for some leftover travis references I found but will merge as soon as this goes green.

@mramato mramato merged commit 9198829 into main Oct 25, 2023
9 checks passed
@mramato mramato deleted the github-actions branch October 25, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants