-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint and eslint-config-cesium #11996
Conversation
Thank you for the pull request, @ggetz! ✅ We can confirm we have a CLA on file for you. |
@ggetz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a handful of comments.
I'll also add after actually seeing it in action I still don't think I like this new "flat config". It just seems harder to actually grok and parse what's happening in different parts of the project. but that's just me, no avoiding it if we want to keep up to date.
@jjspace This should be ready for another look. |
Apparently prettier didn't like that merge but I touched it up quick. LGTM, thanks @ggetz! |
Description
Following up from CesiumGS/eslint-config-cesium#6, this bumps the version of eslint and corresponding packages. The major change is a migration from
.eslintrc.js
files to flat config files.Other notable changes include:
package.json
and corresponding config to.github/actions/check-for-cla
. This was mainly to make eslint happy, but is probably better practice anyway to ensure version compatibility with dependencies.Issue number and link
N/A
Testing plan
npm eslint
and confirm there are no issuesnpm eslint
.Author checklist
CONTRIBUTORS.md
I have updatedCHANGES.md
with a short summary of my changeI have added or updated unit tests to ensure consistent code coverageI have update the inline documentation, and included code examples where relevant