Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ease of use for Non-WGS84 Ellipsoids #12000

Merged
merged 14 commits into from
Jun 11, 2024
Merged

Ease of use for Non-WGS84 Ellipsoids #12000

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
efe698e
Draft, moon sandcastle
ggetz May 14, 2024
65a1951
Updates for non-WGS84 ellipsoids
ggetz May 20, 2024
f221dbb
Clean up API naming, specs
ggetz May 24, 2024
a541374
Cleanup geometries, baselayer picker
ggetz May 24, 2024
4387c7d
Cleanup geometries, baselayer picker
ggetz May 24, 2024
23bfc95
Cleanup
ggetz May 24, 2024
439ad49
Cleanup
ggetz May 24, 2024
eed6702
Merge branch 'main' into ellipsoids
ggetz Jun 10, 2024
35d8c63
Update packages/engine/Source/Scene/Globe.js
ggetz Jun 10, 2024
8f28afe
Update inline docs
ggetz Jun 10, 2024
189c80b
SkyBox helper function
ggetz Jun 10, 2024
1376c9a
Remove extraneous comment
ggetz Jun 10, 2024
8a09dff
Merge branch 'main' into ellipsoids
ggetz Jun 10, 2024
66d8580
Fix icon in baselayerpicker
ggetz Jun 10, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup
  • Loading branch information
@ggetz
ggetz committed May 24, 2024
commit 439ad493251ba59664983d112ddbd230ecdd2d41
2 changes: 1 addition & 1 deletion packages/engine/Source/Renderer/UniformState.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,7 +1319,7 @@ function setSunAndMoonDirections(uniformState, frameState) {
);
}

let position = Simon1994PlanetaryPositions.computeSunPositionInMoonInertialFrame(
let position = Simon1994PlanetaryPositions.computeSunPositionInEarthInertialFrame(
frameState.time,
uniformState._sunPositionWC
);
Expand Down