Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add japan building data sandcastle #12013

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Add japan building data sandcastle #12013

merged 2 commits into from
Jun 3, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jun 3, 2024

Description

  • create a sandcastle to highlight our new Japan building dataset
  • Includes a few POIs in different locations to showcase the data
    • I planned to add translations for the dropdown, those should come shortly.
  • I opted for a light that comes from the camera to avoid nighttime making the buildings darker
  • I turned on antialiasing as it helps a lot with the edges of buildings especially in the areas that have actual imagery textures. @ggetz is there anything else that might make sense as "easy wins" to increase the visual quality?

Issue number and link

No issue

Testing plan

  • Run npm start
  • open sandcastle and navigate to the Japan Buildings one
  • Test the sandcastle and make sure it behaves well
  • Make sure it shows up in search and the categories make sense
  • Make sure the thumbnail looks good

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have update the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code
Copy link

github-actions bot commented Jun 3, 2024

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@ggetz
Copy link
Contributor

ggetz commented Jun 3, 2024

I turned on antialiasing as it helps a lot with the edges of buildings especially in the areas that have actual imagery textures. @ggetz is there anything else that might make sense as "easy wins" to increase the visual quality?

👍 That should be good for now. Other options like increasing the resolution could have performance implications, so let's hold off.

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @jjspace !

@jjhembd jjhembd merged commit b78ce3b into main Jun 3, 2024
9 checks passed
@jjhembd jjhembd deleted the japan-sandcastle branch June 3, 2024 16:32
@jjspace jjspace mentioned this pull request Jun 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants