Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera space/sky interaction #1954

Merged
merged 10 commits into from
Jul 28, 2014
Merged

Camera space/sky interaction #1954

merged 10 commits into from
Jul 28, 2014

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Jul 24, 2014

I re-added the ability to rotate the camera around the globe when the mouse position doesn't pick the globe. Also, the mode switches, at a height close to terrain (configurable), to looking around the camera when the mouse doesn't pick terrain.

@emackey
Copy link
Contributor

emackey commented Jul 24, 2014

This is awesome stuff @bagnell. @pjcozzi do you want to look at the code before merge?

@mramato
Copy link
Contributor

mramato commented Jul 24, 2014

Usability issue:

  1. Start Viewer
  2. Rotate by clicking and dragging the mouse in space
  3. If you drag through the earth, the rotation stops the moment you are off the earth. Shouldn't it switch modes again?
@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

CC #1060

@bagnell
Copy link
Contributor Author

bagnell commented Jul 24, 2014

Usability issue:

  1. Start Viewer
  2. Rotate by clicking and dragging the mouse in space
  3. If you drag through the earth, the rotation stops the moment you are off the earth. Shouldn't it >switch modes again?

@mramato How's that? The camera will stay in whatever mode it started in.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

If I keep dragging in the sky to look up, I can flip the scene upside down:

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

Should middle-mouse drag also do this? Now, we tilt with middle-mouse drag and then tilt again with left-mouse drag?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

Does this also work for touch events? If not, no need to do it now unless it is trivial, but let's submit an issue for it.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

Perhaps not related to this branch (submitting a separate issue is fine), but go into Columbus View and then use the middle-mouse to go under the map:

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

Is this supposed to work in Columbus view? The map quickly disappears and then because awkwardly tilted.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

@bagnell can you include this in the camera animated gif(s) for the 1.0 release blog? CC @shunter

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 24, 2014

Just those issues. Code looks fine. I really dig this.

@mramato
Copy link
Contributor

mramato commented Jul 25, 2014

@mramato How's that? The camera will stay in whatever mode it started in.

Much better.

@emackey emackey mentioned this pull request Jul 25, 2014
@emackey
Copy link
Contributor

emackey commented Jul 25, 2014

I don't mind the upside-down flip. It feels like the user was really asking for it.

@emackey emackey added the 1.0 label Jul 28, 2014
@bagnell
Copy link
Contributor Author

bagnell commented Jul 28, 2014

@pjcozzi This is ready. I'm submitting issues for touch events and tilting under the map in Columbus view. The tilting under the map is still there because I'm using the old code for tilting when the camera height is greater than the height for picking terrain.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 28, 2014

Did you try this?

Should middle-mouse drag also do this? Now, we tilt with middle-mouse drag and then tilt again with left-mouse drag?

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 28, 2014

Should middle-mouse drag also do this? Now, we tilt with middle-mouse drag and then tilt again with left-mouse drag?

Looks good. Not sure what I did to miss it.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jul 28, 2014

@bagnell update CHANGES.md and this is ready.

@bagnell
Copy link
Contributor Author

bagnell commented Jul 28, 2014

@bagnell update CHANGES.md and this is ready.

@pjcozzi Done.

pjcozzi added a commit that referenced this pull request Jul 28, 2014
@pjcozzi pjcozzi merged commit 17025da into master Jul 28, 2014
@pjcozzi pjcozzi deleted the camera-rotate-look branch July 28, 2014 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants