Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TileBoundingRegion.distanceToCamera to use OBB distance in 3D #9678

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Update TileBoundingRegion.distanceToCamera to use OBB distance in 3D #9678

merged 2 commits into from
Jul 15, 2021

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Jul 15, 2021 •
edited
Loading

Reverts #9657 and fixes #9534 (again).

This fix is safe to add back to master becasuse #9670 was just merged.
@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.
@ebogo1
Copy link
Contributor Author

ebogo1 commented Jul 15, 2021

Confirmed that the Fireworks sandcastle passes in Chrome (where it previously failed) with this PR on Windows 10.
@lilleyse
Copy link
Contributor

Thanks @ebogo1
@lilleyse lilleyse merged commit 7784e70 into master Jul 15, 2021
@lilleyse lilleyse deleted the revert-9657-revert-9652-distance-camera-fix branch July 15, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@ebogo1 @cesium-concierge @lilleyse