This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
feat(mam): Return UUID as the repsonse of send MAM message #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Jun 23, 2020
|
I am not convinced that this pull request can make MAM APIs non-blocking. Can you explain? |
This is a working in process draft PR. I will buffer the request of |
jserv
reviewed
Jun 24, 2020
howjmay
force-pushed
the
non_block
branch
2 times, most recently
from
60e05e2
to
0ad894a
Compare
howjmay
force-pushed
the
non_block
branch
9 times, most recently
from
b4085b2
to
2f0ce4c
Compare
jserv
reviewed
Jul 23, 2020
jserv
reviewed
Jul 23, 2020
howjmay
force-pushed
the
non_block
branch
10 times, most recently
from
0c15f71
to
cc9eaa2
Compare
howjmay
force-pushed
the
non_block
branch
11 times, most recently
from
85c919f
to
1345740
Compare
howjmay
force-pushed
the
non_block
branch
2 times, most recently
from
1f5f104
to
d4128db
Compare
jserv
reviewed
Aug 19, 2020
jserv
approved these changes
Aug 19, 2020
|
Pending for CI pipeline. |
howjmay
force-pushed
the
non_block
branch
2 times, most recently
from
4193a87
to
7c4e8f0
Compare
jserv
reviewed
Sep 21, 2020
jserv
reviewed
Sep 21, 2020
howjmay
force-pushed
the
non_block
branch
2 times, most recently
from
07e09c8
to
bd45f5b
Compare
Tangle-accelerator would respond an UUID for every `send_mam_message()` request. The requests would be buffered, and they will be published with another background thread which is in `periodical_task.[c, h]`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tangle-accelerator would respond an UUID for every
send_mam_message()request. This UUID can be used as querying data for
api_fetch_buffered_request_status().api_fetch_buffered_request_status()serves as the API to searchthe current status of both buffered MAM request and buffered
transaction objects.
Closes #624