Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly property is never showing in Inspector for Variable References #140

Open
Monsoonexe opened this issue Feb 7, 2021 · 0 comments
Open

Readonly property is never showing in Inspector for Variable References #140

Monsoonexe opened this issue Feb 7, 2021 · 0 comments

Comments

@Monsoonexe
Copy link

I believe there is a bug with VariableReferences where the Readonly property never shows when appropriate. The code in BaseVariableEditor says to return if the variable "IsClampable". I believe this should be changed to "_isClamped.boolValue".

I believe the intention is that some instances of an variable (say an IntVar) can be readonly, and some other instances can be set as not readonly. The current behaviour is that if something is clampable (like an IntVar), then it cannot be readonly, instead of if the variable is currently set to be clamped.

So currently, IntVars cannot be readonly, and only classes like Vector2Var can be readonly.

image
Monsoonexe added a commit to Monsoonexe/ScriptableObject-Architecture that referenced this issue Feb 7, 2021
@Monsoonexe
Update BaseVariableEditor.cs
6c61835 
fixes DanielEverland#140
if(IsClampable) -> if(_isClamped.boolValue)

fixes DanielEverland#141
now invokes Raise event when value changed in Inspector

Adds a "Raise" button to invoke event.
@Monsoonexe Monsoonexe mentioned this issue Feb 7, 2021
Closed
@simonbucher simonbucher mentioned this issue Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@Monsoonexe