Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multiselectfield): Use original repo #10420

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Jun 17, 2024

https://github.com/goinnn/django-multiselectfield looks like alive again (goinnn/django-multiselectfield#141) with more fixes (including Django 5 support - needed for #10409) than https://github.com/DefectDojo/django-multiselectfield.

django-multiselectfield in version 0.1.13 was released and it is pinned in requirements.txt now

Copy link

dryrunsecurity bot commented Jun 17, 2024

Hi there 👋, @DryRunSecurity here, below is a summary of our analysis and findings.

DryRun Security Status Findings
Server-Side Request Forgery Analyzer 0 findings
Configured Codepaths Analyzer 0 findings
IDOR Analyzer 0 findings
Sensitive Files Analyzer 1 finding
SQL Injection Analyzer 0 findings
Authn/Authz Analyzer 0 findings
Secrets Analyzer 0 findings

Note

🟢 Risk threshold not exceeded.

Change Summary (click to expand)

The following is a summary of changes in this pull request made by me, your security buddy 🤖. Note that this summary is auto-generated and not meant to be a definitive list of security issues but rather a helpful summary from a security perspective.

Summary:

The provided code change is an update to the requirements.txt file for the DefectDojo project, which is an open-source application security management tool. The key changes include updating the outdated django-multiselectfield library to the latest version and pulling the django-tagging library directly from the project's GitHub repository, likely to use a custom version or a version that is not yet publicly released.

From a security perspective, the update to django-multiselectfield is a positive step, as keeping dependencies up-to-date is crucial for maintaining the security of the application. However, the use of a custom version of the django-tagging library may introduce potential security risks if the changes are not thoroughly reviewed and validated. Additionally, the comment about the django-tagging library being "very outdated" suggests that there may be other outdated dependencies in the project, which should be regularly reviewed and updated to address known security vulnerabilities. It's important to ensure that all dependencies in the requirements.txt file are necessary and secure, as this file is an essential part of the application's configuration.

Files Changed:

  • requirements.txt: This file has been updated to include the following changes:
    1. The outdated django-multiselectfield library has been updated from the GitHub repository to the latest version 0.1.13.
    2. The django-tagging library is being pulled directly from the develop branch of the DefectDojo GitHub repository, likely to use a custom version or a version that is not yet publicly released.

Powered by DryRun Security

@kiblik kiblik closed this Jun 17, 2024
@kiblik kiblik reopened this Jun 17, 2024
@kiblik kiblik mentioned this pull request Jun 17, 2024
2 tasks
@kiblik kiblik closed this Jul 2, 2024
@kiblik kiblik reopened this Jul 2, 2024
@kiblik kiblik closed this Jul 2, 2024
@kiblik kiblik reopened this Jul 2, 2024
@Maffooch
Copy link
Contributor

Maffooch commented Jul 3, 2024

If we move away from the fork, I would prefer we wait for a pinned release. It looks like it should be happening any day now!
goinnn/django-multiselectfield@d78d652

@kiblik
Copy link
Contributor Author

kiblik commented Jul 3, 2024

If we move away from the fork, I would prefer we wait for a pinned release. It looks like it should be happening any day now! goinnn/django-multiselectfield@d78d652

Sorry for not updating the description. I already used the pinned version.

Copy link
Contributor

@Maffooch Maffooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have looked at the diff again before commenting that 😅

@kiblik
Copy link
Contributor Author

kiblik commented Jul 3, 2024

There is missing git tag and release but it was already published to pip server: https://pypi.org/project/django-multiselectfield/#history

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants