Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#6662 public traces, part 6: invariant_checker #6861

Merged
merged 17 commits into from
Jul 10, 2024

Conversation

edeiana
Copy link
Contributor

@edeiana edeiana commented Jun 29, 2024

OFFLINE_FILE_TYPE_ARCH_REGDEPS traces lack some markers and have instructions with DR_ISA_REGDEPS encodings, which don't have all the necessary information to perform all the invariant checks.
Here we disable or modify some checks for invariant errors to handle OFFLINE_FILE_TYPE_ARCH_REGDEPS synthetic traces in the invariant_checker tool.

Specifically, we disable:

  • the check for maybe-blocking syscall markers always being preceded by a regular syscall marker, as we don't have regular syscall markers in OFFLINE_FILE_TYPE_ARCH_REGDEPS traces;
  • the setting of branch targets, as they are not saved as first source operand in DR_ISA_REGDEPS instructions;
  • the check for "Missing read/write records", as we can't check for predicated instructions in OFFLINE_FILE_TYPE_ARCH_REGDEPS traces and we can't infer the precise number of load/stores performed by DR_ISA_REGDEPS instructions to adjust the read/write counters accordingly;

We modify the check for matching loads/stores performed by a DR_ISA_REGDEPS fetched instruction with the subsequent read/write records, by requiring that if a DR_ISA_REGDEPS instruction performs a load/store (we use the instruction category to determine that), at least one subsequent read/write record must be present.

Issue #6662

@edeiana edeiana marked this pull request as draft June 29, 2024 22:34
core/ir/instr_shared.c Outdated Show resolved Hide resolved
suite/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@edeiana edeiana marked this pull request as ready for review July 1, 2024 13:25
clients/drcachesim/tools/filter/record_filter.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tools/invariant_checker.cpp Outdated Show resolved Hide resolved
clients/drcachesim/tools/invariant_checker.cpp Outdated Show resolved Hide resolved
suite/tests/CMakeLists.txt Outdated Show resolved Hide resolved
core/ir/instr_shared.c Outdated Show resolved Hide resolved
@edeiana edeiana merged commit 92a44cc into master Jul 10, 2024
17 checks passed
@edeiana edeiana deleted the i6662-regdeps-invariant-checker branch July 10, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants