Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new Light Color Mode Option (HS+Color Temp) #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TarcisioMenezes
Copy link

@TarcisioMenezes TarcisioMenezes commented Feb 27, 2022

Proposed change*

Adding a new light_color_mode option called "Hue - Saturation and Color Temperature".
This new option is a combination of "Color Temperature" and "Hue - Saturation" options that already exist.
Now both can be used at the same time.

Resolves #239

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.
Adding  a new color mode that combines Hue Saturation and Color Temperature.
@github-actions
Copy link
Contributor

Hey @TarcisioMenezes, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2022

Hey @TarcisioMenezes,

❌ It looks like there are some issues with your contribution. Don't worry, here's some additional information and guidance on how to solve them.

  • Your submission includes some code style issues. We invite you to inspect the output of the Pull Request checks and fix reported errors and warnings.
  • Your files are not properly formatted. Did you remember to run npm run format before submitting your changes?

Please fix reported issues, then submit your updates here. If you have any questions or doubts, you can always contact a project maintainer. :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant