Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IKEA ICTC-G-1 ZHA fixes and improvements. #432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElectricFighter
Copy link

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Proposed change*

  • Fix non working controller ICTC-G-1 on ZHA integration by adding newly observed ZHA events.

  • Add actions on quick rotation of the controller as the original Ikea integration: Turn on/Turn off, Prev track/Next track (Currently ZHA only); includes changes to light and mediaplayer hooks for the controller.

Can be used as base to fix other issues found with Ikea controllers using new ZHA events:

  • Rotate left: move_MoveMode.Down_195
  • Rotate right: move_with_on_off_MoveMode.Up_195
  • Stop: stop_with_on_off
  • Rotate left quick: move_to_level_with_on_off_0_1
  • Rotate right quick: move_to_level_with_on_off_255_1

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.
Fix non working controller on ZHA by adding newly observed ZHA events;

Add actions on quick rotation of the controller as the original Ikea integration.
@github-actions
Copy link
Contributor

Hey @ElectricFighter, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant