Add support for some Symfonisk controllers which have different event… #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… names. Info about mine: Firmware: 0x21022631 Quirk: zhaquirks.ikea.symfonisk.IkeaSYMFONISK1 Fixes EPMatt#423.
|
Hey @zapp42, thank you so much for your contribution! 🚀 🔄 We're currently running a few checks to make sure that everything is great with your contribution. Results are coming soon, stay tuned! |
|
Can confirm that this fixes all problems with my Symfonisk, before only play/pause worked. |
|
Is anyone able to approve this PR? |
motoridersd
reviewed
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… names.
Info about mine:
Firmware: 0x21022631
Quirk: zhaquirks.ikea.symfonisk.IkeaSYMFONISK1
Fixes #423.
Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.
Sections marked as * are required and need to be filled in.
Breaking change
If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.
Note: Remove this section if this PR is NOT a breaking change.
Proposed change*
Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put
closes #XXXXin this section to auto-close relevant issues.Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.
Make sure to provide enough information so that your pull request can be reviewed.
Checklist*
npm run formatbefore submitting my Pull Request.