Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport #12050] [Fixes #12049] Adapt the SLD and XML upload forms to the new progress API #12075

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

giohappy
Copy link
Contributor

@giohappy giohappy commented Mar 21, 2024

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

… API (#12050)

* Adapt SLD and XML forms to the new API

* change source name and delete execution when completed
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Mar 21, 2024
@giohappy giohappy added this to the 4.2.3 milestone Mar 21, 2024
@giohappy giohappy linked an issue Mar 21, 2024 that may be closed by this pull request
@giohappy giohappy self-assigned this Mar 21, 2024
@giohappy giohappy changed the title [BAckport #12050] [Fixes 12049] Adapt the SLD and XML upload forms to the new progress API Mar 21, 2024
@giohappy giohappy changed the title [Backport #12050] [Fixes 12049] Adapt the SLD and XML upload forms to the new progress API Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #12075 (2f3afbb) into 4.2.x (d46e227) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.2.x   #12075      +/-   ##
==========================================
- Coverage   63.17%   63.17%   -0.01%     
==========================================
  Files         877      877              
  Lines       52551    52551              
  Branches     6596     6596              
==========================================
- Hits        33200    33198       -2     
- Misses      17828    17831       +3     
+ Partials     1523     1522       -1     
@giohappy giohappy merged commit 650deb4 into 4.2.x Mar 21, 2024
12 of 15 checks passed
@giohappy giohappy deleted the backport-12050-to-4.2.x branch March 21, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA Bot: community license agreement signed
2 participants