exitOnIssue flag #97
exitOnIssue flag #97
Conversation
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
=======================================
Coverage 96.77% 96.77%
=======================================
Files 2 2
Lines 31 31
Branches 7 7
=======================================
Hits 30 30
Misses 1 1Continue to review full report at Codecov.
|
|
Please merge this, the package becomes very useful now. |
|
@GertjanReynaert do you have some time to review this PR? Would love to see this feature released. |
There was a problem hiding this comment.
Hey @tay1orjones, first of all, apologies for the late response.
Are you still up to finishing this pr? If not, no problem, just let me know.
Apart from the rebase that needs to happen, I have a few remarks that are written down in the review I did.
| @@ -174,6 +174,12 @@ these messages. | |||
| afterReporting: () => {}, | |||
| } | |||
| ``` | |||
| - `exitOnIssue` (optional, default: `true`) | |||
There was a problem hiding this comment.
Can you change this default to false since that's the default you used here
| @@ -40,6 +41,7 @@ export default ({ | |||
| duplicateIds.forEach(id => { | |||
| console.log(' ', `Duplicate message id: ${red(id)}`); | |||
| }); | |||
| exitOnIssue ? process.exitCode = 1 : null; | |||
There was a problem hiding this comment.
Can you move this line to the line after this line in the outputDuplicateKeys core method? Since the printer methods should only be concerned about printing to the console, it doesn't really fit here.
| @@ -48,7 +50,7 @@ export default ({ | |||
|
|
|||
| printLanguageReport: langResults => { | |||
| header(`Maintaining ${yellow(langResults.languageFilename)}:`); | |||
| printResults({ ...langResults.report, sortKeys }); | |||
| printResults({ ...langResults.report, sortKeys, exitOnIssue }); | |||
There was a problem hiding this comment.
Can you move this exitOnIssue implementation to this line in the reportLanguage core method? Same reason as the previous comment.
|
Any plans to move forward with that? |
|
What are the blocking points for the PR atm ? That would be a great feature for me ! |
Should resolve #88 and enable the CLI to exit with code
1for CI build tools, etcIncludes documentation/usage updates
Let me know what you think @GertjanReynaert 🙂