[SidePanel API] Adds four examples #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oliverdunk this is ready for a tech review. Can we mostly focus on critical improvements? Please include "nice-to-haves" and I will address these on a separate PR next week. Thanks! 🙂🙏 PS: I am missing the copyright comments and some screenshots. I will add those today. |
oliverdunk
previously requested changes
Apr 27, 2023
|
@oliverdunk PTAL 🙏 |
This was referenced May 2, 2023
oliverdunk
approved these changes
May 3, 2023
| @@ -0,0 +1,22 @@ | |||
| const googleURL = 'https://www.google.com'; | |||
| // Allows users to open the side panel by clicking on the action toolbar icon | |||
There was a problem hiding this comment.
Nit: Can we add a newline above here?
Thanks Oliver! Co-authored-by: Oliver Dunk <oliverdunk@google.com>
…sions-samples into sp-samples-new
2qg4svr
pushed a commit
to 2qg4svr/chrome-extensions-samples
that referenced
this pull request
Jun 3, 2023
* Add global side panel * Add multiple panes sample * Add dictionary side panel sample * Add google.com and action click extension * Switch to lowercase * Fix name * Fix links * Add screenshots and links * Tweak google sp * Remove logs * Add install reason * Add default title to action * Change extension names Update readme's * Tweak comments Add aside * increase picture size * Add screenshots * Add spaces * Update screenshots * Update img size * Refactor multiple panels * rename action folder to site-specific * Switch to Side Panel API * Apply suggestions from Tech review p2 Thanks Oliver! Co-authored-by: Oliver Dunk <oliverdunk@google.com> * Add space Change variable --------- Co-authored-by: Oliver Dunk <oliverdunk@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEADLINE: May 5th (to match Chrome Beta 114 release).
Adds three cookbooks and one sample of the new SidePanel API
Global Sidepanel API Sample
The global side panel is visible and accessible to the user on every page, providing easy access to additional information and functionality. With this sample, you can learn how to create and customize your own global sidepanel using the Sidepanel API.
Google.com Side Panel API Sample
This API sample showcases the implementation of a side panel that opens on action click and using a keyboard shortcut. This side panel opens only when the user is on google.com.
Multiple Side Panels API Sample
This example sets a welcome side panel when the extension is first installed, then when the user navigates to a different tab, it replaces it with the main side panel.
Dictionary Side Panel Featured in Google IO API Sample
This API sample showcases a side panel that functions as a dictionary. It uses the context menu to retrieve a word from the page. Currently only defines the terms "extensions" and "popup".