report: sort performance audits based on impact (#15445)

GoogleChrome · Oct 3, 2023 · 896399b · 896399b · vercel · Oct 3, 2023
1 parent 6a4c751
commit 896399b
Show file tree

Hide file tree

Showing 21 changed files with 1,101 additions and 548 deletions.
diff --git a/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap b/cli/test/smokehouse/__snapshots__/report-assert-test.js.snap
@@ -20,6 +20,10 @@ exports[`getAssertionReport works (multiple failing) 1`] = `
         \\"numericValue\\": 0.13570762803819444,
         \\"numericUnit\\": \\"unitless\\",
         \\"displayValue\\": \\"0.136\\",
+        \\"scoringOptions\\": {
+          \\"p10\\": 0.1,
+          \\"median\\": 0.25
+        },
         \\"details\\": {
           \\"type\\": \\"debugdata\\",
           \\"items\\": [
@@ -46,6 +50,10 @@ exports[`getAssertionReport works (trivial failing) 1`] = `
         \\"numericValue\\": 0.13570762803819444,
         \\"numericUnit\\": \\"unitless\\",
         \\"displayValue\\": \\"0.136\\",
+        \\"scoringOptions\\": {
+          \\"p10\\": 0.1,
+          \\"median\\": 0.25
+        },
         \\"details\\": {
           \\"type\\": \\"debugdata\\",
           \\"items\\": [

diff --git a/core/audits/audit.js b/core/audits/audit.js
@@ -6,7 +6,6 @@
 
 import * as LH from '../../types/lh.js';
 import {isUnderTest} from '../lib/lh-env.js';
-import * as statistics from '../lib/statistics.js';
 import {Util} from '../../shared/util.js';
 
 const DEFAULT_PASS = 'defaultPass';
@@ -105,14 +104,7 @@ class Audit {
    * @return {number}
    */
   static computeLogNormalScore(controlPoints, value) {
-    let percentile = statistics.getLogNormalScore(controlPoints, value);
-    // Add a boost to scores of 90+, linearly ramping from 0 at 0.9 to half a
-    // point (0.005) at 1. Expands scores in (0.9, 1] to (0.9, 1.005], so more top
-    // scores will be a perfect 1 after the two-digit `Math.floor()` rounding below.
-    if (percentile > 0.9) { // getLogNormalScore ensures `percentile` can't exceed 1.
-      percentile += 0.05 * (percentile - 0.9);
-    }
-    return Math.floor(percentile * 100) / 100;
+    return Util.computeLogNormalScore(controlPoints, value);
   }
 
   /**
@@ -411,8 +403,11 @@ class Audit {
       errorMessage: product.errorMessage,
       errorStack: product.errorStack,
       warnings: product.warnings,
+      scoringOptions: product.scoringOptions,
+      metricSavings: product.metricSavings,
 
       details: product.details,
+      guidanceLevel: audit.meta.guidanceLevel,
     };
   }
 

diff --git a/core/audits/byte-efficiency/uses-long-cache-ttl.js b/core/audits/byte-efficiency/uses-long-cache-ttl.js
@@ -9,7 +9,7 @@ import parseCacheControl from 'parse-cache-control';
 import {Audit} from '../audit.js';
 import {NetworkRequest} from '../../lib/network-request.js';
 import UrlUtils from '../../lib/url-utils.js';
-import {linearInterpolation} from '../../lib/statistics.js';
+import {linearInterpolation} from '../../../shared/statistics.js';
 import * as i18n from '../../lib/i18n/i18n.js';
 import {NetworkRecords} from '../../computed/network-records.js';
 

diff --git a/core/audits/metrics/cumulative-layout-shift.js b/core/audits/metrics/cumulative-layout-shift.js
@@ -62,11 +62,14 @@ class CumulativeLayoutShift extends Audit {
       items: [rest],
     };
 
+    const scoringOptions = {p10: context.options.p10, median: context.options.median};
+
     return {
       score: Audit.computeLogNormalScore(
-        {p10: context.options.p10, median: context.options.median},
+        scoringOptions,
         cumulativeLayoutShift
       ),
+      scoringOptions,
       numericValue: cumulativeLayoutShift,
       numericUnit: 'unitless',
       displayValue: cumulativeLayoutShift.toLocaleString(context.settings.locale),

diff --git a/core/audits/metrics/first-contentful-paint.js b/core/audits/metrics/first-contentful-paint.js
@@ -74,6 +74,7 @@ class FirstContentfulPaint extends Audit {
         options.scoring,
         metricResult.timing
       ),
+      scoringOptions: options.scoring,
       numericValue: metricResult.timing,
       numericUnit: 'millisecond',
       displayValue: str_(i18n.UIStrings.seconds, {timeInMs: metricResult.timing}),

diff --git a/core/audits/metrics/largest-contentful-paint.js b/core/audits/metrics/largest-contentful-paint.js
@@ -83,6 +83,7 @@ class LargestContentfulPaint extends Audit {
         options.scoring,
         metricResult.timing
       ),
+      scoringOptions: options.scoring,
       numericValue: metricResult.timing,
       numericUnit: 'millisecond',
       displayValue: str_(i18n.UIStrings.seconds, {timeInMs: metricResult.timing}),

diff --git a/core/audits/metrics/speed-index.js b/core/audits/metrics/speed-index.js
@@ -77,6 +77,7 @@ class SpeedIndex extends Audit {
         options.scoring,
         metricResult.timing
       ),
+      scoringOptions: options.scoring,
       numericValue: metricResult.timing,
       numericUnit: 'millisecond',
       displayValue: str_(i18n.UIStrings.seconds, {timeInMs: metricResult.timing}),

diff --git a/core/audits/metrics/total-blocking-time.js b/core/audits/metrics/total-blocking-time.js
@@ -107,6 +107,7 @@ class TotalBlockingTime extends Audit {
         options.scoring,
         metricResult.timing
       ),
+      scoringOptions: options.scoring,
       numericValue: metricResult.timing,
       numericUnit: 'millisecond',
       displayValue: str_(i18n.UIStrings.ms, {timeInMs: metricResult.timing}),