Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps(yargs): upgrade to 17.3.1 #13590

Merged
merged 21 commits into from
Jan 26, 2022
Merged

deps(yargs): upgrade to 17.3.1 #13590

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4798796
update
connorjclark Jan 25, 2022
5d1f2ca
go back to being nully
connorjclark Jan 25, 2022
544e0cb
update types
connorjclark Jan 25, 2022
c4e8df4
tweak
connorjclark Jan 25, 2022
3cd1441
tweak extraHeaders coerce
connorjclark Jan 25, 2022
c23ea16
comments
connorjclark Jan 25, 2022
977d400
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark Jan 25, 2022
2324848
tests: add snapshot tests for cli-flags.js
connorjclark Jan 25, 2022
e076404
normalize
connorjclark Jan 25, 2022
994c974
slashes
connorjclark Jan 25, 2022
a3e1a71
Merge remote-tracking branch 'origin/flags-snapshots' into update-yargs
connorjclark Jan 25, 2022
90a07d1
update
connorjclark Jan 25, 2022
d288da1
update
connorjclark Jan 25, 2022
a5ce390
g
connorjclark Jan 25, 2022
f5c3d50
Merge remote-tracking branch 'origin/flags-snapshots' into update-yargs
connorjclark Jan 25, 2022
c529920
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark Jan 26, 2022
80ed3e7
snap
connorjclark Jan 26, 2022
64fce54
dont need those
connorjclark Jan 26, 2022
c539e48
Merge remote-tracking branch 'origin/master' into update-yargs
connorjclark Jan 26, 2022
08878c0
tweak
connorjclark Jan 26, 2022
5c35f44
update
connorjclark Jan 26, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tweak extraHeaders coerce
  • Loading branch information
@connorjclark
connorjclark committed Jan 25, 2022
commit 3cd1441145ca766fa4f59e0cef9161d30e50ba04
2 changes: 1 addition & 1 deletion lighthouse-cli/cli-flags.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ function coerceLocale(value) {
*/
function coerceExtraHeaders(value) {
// TODO: this function does not actually verify the object type.
if (value === undefined) return value;
if (value === undefined) return null;
if (typeof value === 'object') return /** @type {LH.SharedFlagsSettings['extraHeaders']} */ (value);
if (typeof value !== 'string') {
throw new Error(`Invalid value: Argument 'extra-headers' must be a string`);
Expand Down
1 change: 1 addition & 0 deletions lighthouse-core/test/results/sample_v2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5892,6 +5892,7 @@
"locale": "en-US",
"blockedUrlPatterns": null,
"additionalTraceCategories": null,
"extraHeaders": null,
"precomputedLanternData": null,
"onlyAudits": null,
"onlyCategories": null,
Expand Down