Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: remove use of innerHTML to empty elements #15911

Merged
merged 1 commit into from
Apr 2, 2024
Merged

report: remove use of innerHTML to empty elements #15911

merged 1 commit into from
Apr 2, 2024

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Apr 2, 2024 •
edited
Loading

ref #15884
and crbug.com/331086923

While this isn't a security problem, we don't need this code to keep popping up in security scanners.

i'm open to using elem.replaceChildren() instead, if that seems clearer.
@paulirish paulirish requested a review from a team as a code owner April 2, 2024 22:19
@paulirish paulirish requested review from adamraine and removed request for a team April 2, 2024 22:19
@devtools-bot devtools-bot merged commit 458ded8 into main Apr 2, 2024
29 checks passed
@devtools-bot devtools-bot deleted the noinnerhtml branch April 2, 2024 22:35
adamraine pushed a commit that referenced this pull request Apr 8, 2024
@paulirish @adamraine
report: remove use of innerHTML to empty elements (#15911)
6dc8cee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting4reviewer
4 participants
@paulirish @connorjclark @adamraine @devtools-bot