core(trace-processor): correct overlapping tasks #15921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
commented
Apr 4, 2024
| @@ -304,7 +304,7 @@ describe('Long tasks audit', () => { | |||
| }], | |||
| }, | |||
| }); | |||
| expect(result.metricSavings.TBT).toBeApproximately(353.53); | |||
| expect(result.metricSavings.TBT).toBeApproximately(171.95); | |||
There was a problem hiding this comment.
I checked, this trace does have overlapping events: https://trace.cafe/t/ETHMnpFcQx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks can sometimes be overlapping as of M122: https://crbug.com/329678173
This probably needs a fix for the trace events themselves, but until then we can approximate the correct behavior by cutting of tasks that overlap with the next task.
Ref #15896