core(lantern): rename NetworkRequest record to rawRequest #16037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 4, 2024
| .reduce((map, node) => map.set(node.record, node), new Map()); | ||
| const originalNodesByRequest = Array.from(simulationBeforeChanges.nodeTimings.keys()) | ||
| // @ts-expect-error we don't care if all nodes without a request collect on `undefined` | ||
| .reduce((map, node) => map.set(node.request, node), new Map()); |
There was a problem hiding this comment.
rawRequest is not necessarily unique (well it may be, but let's not require it. how redirects are handled may not adhere to this constraint atm). so just use request as a key.
adamraine
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
record(the impl-specific source of truth) andrequest(aka LanternRequest) are too close to each other, and that was causing bugs, and the terms were not used consistently inside Lantern, so this PR fixes all that. Now:requestis used everywhere for LanternRequestrecordwithrawRequestas a property accessible on a LanternRequest and NetworkNoderef #15841