Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(i18n): no ICU value given to preprocess #9384

Merged
merged 4 commits into from
Jul 17, 2019
Merged

tests(i18n): no ICU value given to preprocess #9384

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
587980c
Add test for ICU msg w/o values against preprocessMsgValues.
exterkamp Jul 16, 2019
7b1896d
removed import because test changed!
exterkamp Jul 16, 2019
db5a70a
updated with another test. added var to error out.
exterkamp Jul 17, 2019
9b73f54
Update lighthouse-core/test/lib/i18n/i18n-test.js
exterkamp Jul 17, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed import because test changed!
  • Loading branch information
@exterkamp
exterkamp committed Jul 16, 2019
commit 7b1896d733b72eb48cdc606641c3ead7d46e8b87
1 change: 0 additions & 1 deletion lighthouse-core/lib/i18n/i18n.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,6 @@ function replaceIcuMessageInstanceIds(inputObject, locale) {
module.exports = {
_formatPathAsString,
_ICUMsgNotFoundMsg,
_preprocessMessageValues,
UIStrings,
lookupLocale,
getRendererFormattedStrings,
Expand Down