-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate onFID() and remove previously deprecated APIs #435
Conversation
Test all now passing, but leaving this in draft until we're ready to merge, nearer 12th March. However I'm not planning on adding more to this PR so it is ready for review in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. I left a few suggestions in this PR. In addition, can you:
- Create a
v4
branch and update this PR's merge target to that (instead ofmain
). - Remove references to the "base" script still in
package.json
(in "exports" and "files").
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to remove references to the "base" script in package.json (in "exports" and "files").
Done! |
Makes the following changes assumiong the next release after this merge is a major version bump:
getXXX
calls andReportCallback
)onFID
as deprecated and to be removed in next major versionNavigationTimingPolyfillEntry
)onFID
toonINP
Notable it does NOT: