Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Add Oculus PWA article #7006

Merged
merged 17 commits into from
Jan 10, 2022
Merged

Add Oculus PWA article #7006

merged 17 commits into from
Jan 10, 2022

Conversation

tomayac
Copy link
Member

@tomayac tomayac commented Dec 9, 2021

Fixes #6947.

Changes proposed in this pull request:

  • Add the article.
@chrome-devrel-review-bot
Copy link
Collaborator

chrome-devrel-review-bot commented Dec 9, 2021

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/blog/pwas-on-oculus-2/index.md

  • This file passed all of our automated Markdown audits.
@netlify
Copy link

netlify bot commented Dec 9, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: 8a7b20c

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/61dc06ba3704fe0008310403

😎 Browse the preview: https://deploy-preview-7006--web-dev-staging.netlify.app

@tomayac tomayac changed the title [Do not revew] Add PWA article Dec 9, 2021
@tomayac tomayac self-assigned this Dec 9, 2021
@tomayac tomayac added $-presubmit Add label to run presubmit tests. DO NOT MERGE Actively working on but experimental labels Dec 9, 2021
@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Dec 9, 2021
@tomayac tomayac changed the title [Do not review] Add PWA article Dec 14, 2021
@tomayac tomayac changed the title [Do not review] Add Oculus PWA article Dec 21, 2021
@tomayac tomayac marked this pull request as ready for review December 21, 2021 12:23
@tomayac tomayac added $-presubmit Add label to run presubmit tests. and removed DO NOT MERGE Actively working on but experimental labels Dec 21, 2021
@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Dec 21, 2021
Copy link
Contributor

@jpmedley jpmedley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thomas,

I had more content questions than usual. Since this is such a new topic, I think they're merited. Please consider them carefully.

Joe

src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
src/site/content/en/blog/pwas-on-oculus-2/index.md Outdated Show resolved Hide resolved
tomayac and others added 3 commits December 22, 2021 12:11
Co-authored-by: Joe Medley <jmedley@google.com>
Co-authored-by: Jeremy Wagner <malchata@users.noreply.github.com>
Co-authored-by: Joe Medley <jmedley@google.com>
@tomayac
Copy link
Member Author

tomayac commented Dec 22, 2021

@jpmedley Thanks for the thorough review. I have addressed all your remarks! PTAL. Thanks!

@tomayac tomayac merged commit 296c42d into main Jan 10, 2022
@tomayac tomayac deleted the oculus-pwa branch January 10, 2022 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
4 participants