Add deferred udpates and postMessage fallback #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffposnick
suggested changes
Oct 3, 2018
packages/workbox-broadcast-cache-update/BroadcastCacheUpdate.mjs
Outdated
Show resolved
Hide resolved
packages/workbox-broadcast-cache-update/BroadcastCacheUpdate.mjs
Outdated
Show resolved
Hide resolved
packages/workbox-broadcast-cache-update/BroadcastCacheUpdate.mjs
Outdated
Show resolved
Hide resolved
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin9.97KB gzip'ed (66% of limit) |
philipwalton
force-pushed
the
broadcast-cache-updates
branch
from
b638170
to
a43d01f
Compare
|
Rebased after changing the base branch from |
jeffposnick
approved these changes
Oct 4, 2018
packages/workbox-broadcast-cache-update/BroadcastCacheUpdate.mjs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1399
This PR is an initial pass at making the
workbox-broadcast-cache-updateplugin work with cache updates on navigation requests. It also adds a basic fallback topostMessage()-ing all window clients in browsers that don't support the Broadcast Channel API.Note, this PR includes some breaking changes to go along with some of our plans for v4, so I've tagged it accordingly. I'll update this PR with a complete list of breaking changes after the review, but for now the main points are:
workbox, which will be the same default used byworkbox-window).BroadcastCacheUpdateandbroadcastUpdatemethods now take destructured params rather than position params (which made the most sense since channel name is now optional).