CLI support for --watch #1776
Merged
CLI support for --watch #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin9.81KB gzip'ed (65% of limit) |
philipwalton
approved these changes
Dec 12, 2018
| logger.warn(warning); | ||
| } | ||
|
|
||
| logger.log(`The service worker was written to ${config.swDest}\n` + |
There was a problem hiding this comment.
I'm totally fine if we don't do this, but it might be nice have a slightly different log message in the case of a rebuild do to a watched file changing.
There was a problem hiding this comment.
There's an additional log message at L39 which I think takes care of calling out that distinction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to filing a PR, please:
gulp lint testpasses locally.R: @philipwalton
Fixes #1490
Adds support for a
--watchflag that can be passed to the CLI'sinjectManifestandgenerateSWmodes. If provided, the CLI will stay running and will rebuild the SW whenever one of theglobPatternsmatches changes.