Don't set fetchOptions when request.mode is 'navigate' #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Jan 28, 2019
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin8.82KB gzip'ed (59% of limit) |
|
Yup, the issue remains open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @philipwalton
This is related to #1796, but it doesn't fix it. The workaround that I added to fix it led to issues in Edge, and rather than continue to iterate and try to find a fix for the v4.0.0 release, I'm going to work around the issue by making sure we don't set
fetchOptionswhenrequest.mode === 'navigate'.This is strictly better than the behavior in v3, where you could end up with failed navigations in this scenario.
The ultimate fix is to find the cleanest, cross-browser-compatible way to create a new
Requestwithmodeset to'same-origin'and all of the otherRequestproperties carried over. I'd like to punt on that until after the final v4.0.0 release, though.