Add a cache listener message response #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-Bot Size PluginChanged File Sizes
New Files
All File SizesView Table
Workbox Aggregate Size Plugin8.82KB gzip'ed (59% of limit) |
jeffposnick
suggested changes
Feb 19, 2019
jeffposnick
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
When writing the
workbow-windowdocumentation, I realized that the logic inRouter#addCacheListenerincludes a check formeta === 'workbox-window', but we shouldn't require developers to be useworkbox-windowto cache URLs (or ask them to set that meta value themselves, which wouldn't make sense).This PR removes that check. It also adds a response to the message event if it contains a message channel (which
workbox-windowmessage do by default). This allows users to await successful caching of all URLs, similar to what you get with precaching.Note: I did not add a message response in the event of an error, but I potentially could? WDYT?