Use ignoreSearch to fix precaching broadcast updates. #1914
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will pass
ignoreSearch: true
through to the underlying call tocache.match()
that attempts to find the previously precached entry with the same URL, in order to detect whether there's been an update. This is in turn used by thebroadcast-update
plugin.This is necessary in v4 because the previously cached URL may have a
__WB_REVISION__
URL query parameter.This should only affect cache wrapper usage from within the
PrecacheController
, as in all other uses, thematchOptions
will remainundefined
.CC: @webmaxru