Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a message listener when generateSW is called with skipWaiting: false #1929

Merged
merged 1 commit into from
Feb 28, 2019
Merged

Add a message listener when generateSW is called with skipWaiting: false #1929

merged 1 commit into from
Feb 28, 2019

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton

Fixes #1753

If generateSW is called from our build tools, and skipWaiting is false (the default), the resulting service worker will include a message event listener which checks for event.data.type === 'SKIP_WAITING'. If the service worker receives that message, it will call self.skipWaiting().

We should update our recipes to include an example of this once it gets deployed.
@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.60 KB 3.60 KB 0% 1.56 KB
packages/workbox-broadcast-update/build/workbox-broadcast-update.prod.js 1.85 KB 1.85 KB 0% 930 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 3.64 KB 3.64 KB 0% 1.36 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 579 B 579 B 0% 344 B
packages/workbox-cli/build/app.js 5.58 KB 5.58 KB 0% 1.98 KB
packages/workbox-cli/build/bin.js 1.16 KB 1.16 KB 0% 580 B
packages/workbox-core/build/workbox-core.prod.js 5.46 KB 5.46 KB 0% 2.36 KB
packages/workbox-expiration/build/workbox-expiration.prod.js 2.83 KB 2.83 KB 0% 1.24 KB
packages/workbox-google-analytics/build/workbox-offline-ga.prod.js 1.89 KB 1.89 KB 0% 898 B
packages/workbox-navigation-preload/build/workbox-navigation-preload.prod.js 652 B 652 B 0% 317 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.25 KB 4.25 KB 0% 1.71 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.51 KB 1.51 KB 0% 758 B
packages/workbox-routing/build/workbox-routing.prod.js 3.38 KB 3.38 KB 0% 1.47 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 4.86 KB 4.86 KB 0% 1.19 KB
packages/workbox-streams/build/workbox-streams.prod.js 1.38 KB 1.38 KB 0% 677 B
packages/workbox-sw/build/workbox-sw.js 1.33 KB 1.33 KB 0% 741 B
packages/workbox-webpack-plugin/build/generate-sw.js 5.29 KB 5.29 KB 0% 1.84 KB
packages/workbox-webpack-plugin/build/index.js 349 B 349 B 0% 255 B
packages/workbox-webpack-plugin/build/inject-manifest.js 7.22 KB 7.22 KB 0% 2.48 KB
packages/workbox-window/build/workbox-window.dev.umd.js 30.37 KB 30.37 KB 0% 8.01 KB
packages/workbox-window/build/workbox-window.prod.umd.js 4.65 KB 4.65 KB 0% 1.80 KB

Workbox Aggregate Size Plugin

8.83KB gzip'ed (59% of limit)
22.15KB uncompressed
philipwalton
philipwalton approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@philipwalton philipwalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
@philipwalton philipwalton merged commit bd5f411 into master Feb 28, 2019
@philipwalton philipwalton deleted the skipWaiting-message branch February 28, 2019 22:39
@jeffposnick jeffposnick mentioned this pull request Mar 7, 2019
Merged
@jadbox jadbox mentioned this pull request Mar 15, 2019
Closed
@jadbox jadbox mentioned this pull request Mar 28, 2019
Merged
@Amareis Amareis mentioned this pull request Apr 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@jeffposnick @workbox-pr-bot @philipwalton