Bg sync array buffer #1932
Bg sync array buffer #1932
Conversation
There was a problem hiding this comment.
I'm fine if this is just an interim PR to bridge things until we eventually move off of mocks and onto in-browser unit tests.
But at the same time, I wanted to point out that https://github.com/pinterest/service-workers/blob/master/packages/service-worker-mock/models/ has been updated to match our local models, and this PR will cause a new divergence.
Is it feasible at all to update the mocks in that project, and then use them locally? Or would that overly complicate things?
.eslintrc.js
Outdated
| ignoreUrls: true, | ||
| ignorePattern: '^\\s*import', | ||
| }], | ||
| "ignorePattern": "^\\s*import", |
There was a problem hiding this comment.
These don't need quotes (it's a JS file, not JSON).
And elsewhere where there are quotes, could you switch them back to single and not double?
There was a problem hiding this comment.
I ran eslint or the .eslintrc.js file (not sure why it wasn't already doing that?).
|
I'd rather not put any effort into using their mocks instead of ours since I plan (as the very next thing I work on) to move off the mocks entirely and switch to testing in real browsers. We could let them know about these changes, or submit a PR with them though. |
PR-Bot Size PluginChanged File Sizes
New FilesNo new files have been added. All File SizesView Table
Workbox Aggregate Size Plugin8.77KB gzip'ed (58% of limit) |
R: @jeffposnick
Fixes #1908. This PR mostly cherry-picks commits from the WIP unit-test-updates branch (the first two commits), which means there's some extra stuff in here that might not seem relevant, but it was easier to just cherry-pick existing work that to redo everything. Also that should make merging those changes cleaner in the future.
I kept the tests mostly verbatim from the
unit-tests-updatesbranch since I knew they were passing in all browsers, then I updated the mocks in this branch until I could get them to pass here (I opted to not change the tests since I know they were passing and run correctly in browsers).The most relevant changes are to the StorableRequest class here. The rest of the changes include several small compat issues (e.g. some stuff in the DBWrapper library) I found and fixed in the other branch.