Resolve getSW() to a matching waiting SW #1961
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick
Fixes #1957
This PR updates the logic for how an "own" service worker is resolved in
workbow-window
as follows:If a service worker with a matching
scriptURL
was already waiting to activate at registration time, it is considered to be the "own" service worker and thus will be the service workergetSW()
resolves to.In cases where there's an active and waiting service worker at registration time with a matching
scriptURL
,getSW()
will resolve to the waiting service worker because it's the one that was registered most recently.