Allow wb.removeEventListener to work without an exception

[donavon]

R: @jeffposnick @philipwalton

Fixes #1962

Set does not have a remove method. It should be delete.

[jeffposnick]

Thanks for the catch, @donavon!

One thing that this points to is that the removeEventListener() code path is currently untested. Would you mind if I pushed an additional commit to this PR that added a test to ensure we will catch any regressions?

[donavon]

please do

[jeffposnick]

Merging, unless @philipwalton chimes in with an objection related to the code for the new test...

[philipwalton]

Thanks @donavon! And yeah, embarrassing that we weren't testing the removeEventListener flow.

@jeffposnick I'm fine with merging this as is, but I may refactor the test later and move it into a file that specifically tests the EventTargetShim module

[donavon]

No prob. Please let me know when and what version I can expect an npm package.

[philipwalton]

We have a few bug fixes that might warrant a patch version push. @jeffposnick what do you think? I'm fine with releasing this and the getSW() fix right away unless you have a reason to hold off?

[jeffposnick]

No reason to hold off from my side of things.

[philipwalton]

Ok, I'll do a 4.1.1 release later this afternoon then.

[philipwalton]

4.1.1 has been published 🎉

[donavon]

Thx!

I also found this on your docs site. It needs updated as well.

https://developers.google.com/web/tools/workbox/reference-docs/latest/workbox-window_utils_EventTargetShim.mjs

[philipwalton]

Thanks, that file actually shouldn't even be in the docs since it's private. I've filed an issue to fix that: #1964