Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sw imports sorted #1973

Merged
merged 6 commits into from
Mar 20, 2019
Merged

Make the sw imports sorted #1973

merged 6 commits into from
Mar 20, 2019

Conversation

el
Copy link
Contributor

@el el commented Mar 20, 2019

R: @jeffposnick @philipwalton

Fixes #1972

Description of what's changed/fixed.
Added sorting before generating a hash

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@el
Copy link
Contributor Author

el commented Mar 20, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

coveralls commented Mar 20, 2019

Coverage Status

Coverage decreased (-1.4%) to 76.864% when pulling 614df72 on el:master into d85aea0 on GoogleChrome:master.

@jeffposnick jeffposnick added the Chillin' Not being actively worked on, or deferred for a point in the future. label Mar 20, 2019
@jeffposnick jeffposnick removed the Chillin' Not being actively worked on, or deferred for a point in the future. label Mar 20, 2019
@jeffposnick
Copy link
Contributor

We unfortunately need to update the hashes hardcoded in the unit tests when there's a change that alters the webpack plugin's output.

I'll push a commit to the branch in this PR with the necessary updates.

@jeffposnick jeffposnick self-requested a review March 20, 2019 19:07
Copy link
Contributor

@jeffposnick jeffposnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@jeffposnick jeffposnick merged commit b67ecf6 into GoogleChrome:master Mar 20, 2019
@el
Copy link
Contributor Author

el commented Mar 21, 2019

Thanks for handling the tests. Can you publish a new version to npm? (We have a package layout file that lists all the files and this makes precache file change the name randomly)

@jeffposnick
Copy link
Contributor

Likely within the next week or so—we do try to batch up the changes a bit in between releases.

@el
Copy link
Contributor Author

el commented Mar 21, 2019

Ohh, that works thanks. I will just disable the chunks until then ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants