Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add provider to allowed list #551

Merged
merged 2 commits into from
Mar 13, 2024

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Mar 12, 2024

Description

This PR converts the useAllowedList hook to a context provider. This allows the latest data to be always available and not calculated only when the cookie table is opened.

  • At times, for the first installation of the extension, if any cookie was allowed-listed and the user moved to the landing page and revisited the frame, the CSS might not get applied for those cookies or there might be a delay.

Relevant Technical Choices

Testing Instructions

  • Remove PSAT from the browser if present, and make a fresh install of the extension.
  • Turn on CDP, move to the first frame, and allow-list a third-party cookie.
  • Move out to the landing page and visit back the frame, CSS will be applied correctly.

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #

@mayan-000 mayan-000 self-assigned this Mar 12, 2024
@mayan-000 mayan-000 changed the base branch from release/0.5.3 to release/0.6.0 March 12, 2024 10:51
@mohdsayed mohdsayed added this to the v0.6.0 milestone Mar 12, 2024
@mohdsayed mohdsayed added the bug Something isn't working label Mar 12, 2024
@mayan-000 mayan-000 marked this pull request as ready for review March 13, 2024 04:13
@mohdsayed mohdsayed merged commit 3814d60 into release/0.6.0 Mar 13, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/provider-to-allowed-list branch March 13, 2024 09:12
@mohdsayed mohdsayed mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants