Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Add disabled state to the Button component #585

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Refactor: Add disabled state to the Button component #585

merged 2 commits into from
Apr 3, 2024

Conversation

ayushnirwal
Copy link
Collaborator

Description

Add disabled state to the Button Component and refactor it to be more DRY.

Screenshot/Screencast

Enabled

Screenshot 2024-04-03 at 1 41 02 PM

Disabled

Screenshot 2024-04-03 at 1 41 23 PM

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).
@ayushnirwal ayushnirwal self-assigned this Apr 3, 2024
@ayushnirwal ayushnirwal mentioned this pull request Apr 3, 2024
Merged
9 tasks
@mohdsayed mohdsayed merged commit 5d3aef1 into develop Apr 3, 2024
4 checks passed
@mohdsayed mohdsayed deleted the ref/button branch April 3, 2024 13:29
@mohdsayed mohdsayed added this to the v0.7.0 milestone Apr 11, 2024
@mohdsayed mohdsayed mentioned this pull request Apr 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@ayushnirwal @mohdsayed