Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add Blocked status in CSV report #661

Closed
wants to merge 2 commits into from
Closed

Fix: Add Blocked status in CSV report #661

wants to merge 2 commits into from

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented May 6, 2024 •
edited
Loading

Description

This PR adds code to add Blocked status in the Blocking status column when the CSV file is downloaded.

Relevant Technical Choices

Testing Instructions

  • Open the PSAT panel and enable CDP.
  • Open the cookie table on the first frame.
  • Find the download icon beside the search bar and click it.
  • Open the downloaded file and scroll to the last column.
  • The Blocking status column should have the value Blocked for some cookies.

Additional Information:

Screenshot/Screencast

Screenshot 2024-05-06 at 14 55 19

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #
@mayan-000 mayan-000 self-assigned this May 6, 2024
@mayan-000 mayan-000 marked this pull request as ready for review May 6, 2024 10:59
@mayan-000 mayan-000 requested a review from mohdsayed May 6, 2024 10:59
@mohdsayed
Copy link
Collaborator

Closing as this is not requried for the following reasons.

  1. A cookie having yellow row doesn’t necessarily mean that the cookie was blocked, it just means that it was blocked in at least one of the request or response. Therefore mentioning that the cookie was blocked would be misleading.
  2. PR#539 will remove this column in the next version, so it would anyways not be required.
@mohdsayed mohdsayed closed this May 7, 2024
@mohdsayed mohdsayed deleted the fix/table-report branch May 7, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@mayan-000 @mohdsayed