Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeQueue + WASM example #255

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FreeQueue + WASM example #255

wants to merge 7 commits into from

Conversation

DivyamAhuja
Copy link
Contributor

So here it is!
WebAssembly Example

Hello WebAssembly Example

It takes some time for audio to start, cause of silence in start of audio
DivyamAhuja
DivyamAhuja commented Sep 6, 2022
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
@hoch hoch self-requested a review September 6, 2022 21:38
hoch
hoch reviewed Sep 6, 2022
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR generally looks great! Let's make some improvements over comments. Also README file with some explanations for each file would be really helpful.
.vscode/settings.json Outdated Show resolved Hide resolved
src/_data/audioworklet_data.yaml Outdated Show resolved Hide resolved
src/_data/audioworklet_data.yaml Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/build.sh Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/build/example.worker.js Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Outdated Show resolved Hide resolved
hoch
hoch reviewed Sep 13, 2022
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please pay attention to the style and comments.

One big question is: can we handle the stereo properly?

Other than that, I believe we can wrap this up in the next round of code review.
src/audio-worklet/free-queue/examples/hello-webassembly/README.md Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/README.md Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js

// Pull out render quantum frame from the queue into output.
// If failed, print "failed" to console.
const didPull = this.queue.pull(output, RENDER_QUANTUM);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

return this.queue.pull(output, RENDER_QUANTUM) ? true : false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can return false here.

Then I think audio worklet will just stop 🤔

https://webaudio.github.io/web-audio-api/#callback-audioworketprocess-callback

So I think we should always return true, to keep worklet alive
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Outdated Show resolved Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js Show resolved Hide resolved
@hoch hoch changed the title WebAssembly Example Apr 4, 2023
@hoch hoch added the vault PR that needs review and to be merged if possible label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vault PR that needs review and to be merged if possible
2 participants
@DivyamAhuja @hoch