Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kuberay deployment to gke module #313

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

Add kuberay deployment to gke module #313

wants to merge 11 commits into from

Conversation

Chris113113
Copy link
Collaborator

No description provided.

stevenBorisko
stevenBorisko requested changes Sep 29, 2023
View reviewed changes
Copy link
Collaborator

@stevenBorisko stevenBorisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, only necessary small change to error in the variable documentation
a3/terraform/modules/cluster/gke/variables.tf Outdated Show resolved Hide resolved
a3/terraform/modules/cluster/gke/kubernetes-operations/variables.tf Show resolved Hide resolved
a3/terraform/modules/cluster/gke/kubernetes-operations/aiinfra-ksa.tf Show resolved Hide resolved
soumyapani
soumyapani reviewed Sep 29, 2023
View reviewed changes
a3/terraform/modules/cluster/gke/kubernetes-operations/kubeconfig.tf Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks for doing this.
@soumyapani soumyapani changed the base branch from main to develop October 10, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Chris113113 @stevenBorisko @soumyapani