Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various EgoVehicle PythonAPI fixes #106

Merged
merged 4 commits into from
Apr 24, 2023
Merged

Various EgoVehicle PythonAPI fixes #106

merged 4 commits into from
Apr 24, 2023

Conversation

GustavoSilvera
Copy link
Collaborator

@GustavoSilvera GustavoSilvera commented Apr 22, 2023

Enables non-ego CARLA autopilot vehicles to "see" the DReyeVR EgoVehicle. Discussed in further detail in #104 this patch enables us to keep the DReyeVR name "harplab.dreyevr_vehicle.*" (which has the main benefit of not being included in the many get_actors().filter("vehicle.*") PythonAPI commands) while still allowing the non-ego Autopilot vehicles to detect the DReyeVR EgoVehicle.

Also adding missing EgoVehicle attributes from the Factory back to the EgoVehicle (see #100)

Fixes #104 #100

@GustavoSilvera GustavoSilvera added the bug Something isn't working label Apr 22, 2023
@GustavoSilvera GustavoSilvera self-assigned this Apr 22, 2023
@GustavoSilvera GustavoSilvera changed the title Allow non-ego CARLA autopilot vehicles to "see" the DReyeVR EgoVehicle Apr 22, 2023
Copy link
Contributor

@ajdroid ajdroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ALSM fix. Attribute addition also looks good

@ajdroid ajdroid merged commit 95d1b26 into main Apr 24, 2023
@GustavoSilvera GustavoSilvera deleted the autopilot-bugfix branch April 24, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants