Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve general functionality and usability #74

Merged
merged 15 commits into from
Feb 17, 2023
Merged

Improve general functionality and usability #74

merged 15 commits into from
Feb 17, 2023

Conversation

GustavoSilvera
Copy link
Collaborator

@GustavoSilvera GustavoSilvera commented Jan 8, 2023

  • Replace existing LevelScript with GameMode. This allows us to not need to carry the (large) map blueprint files (ue4 binary) and we can use the vanilla Carla maps. By default we spawn the EgoVehicle in the first of the recommended Carla locations.
  • Use FTransforms in place of several FVector/FRotator (location/rotation) pairs to improve performance and readability.
  • Template metaprogramming for repeated ReadConfigValue<T> functions
  • Adding custom LOG macros for improved DReyeVR logging with file, function, and line number attached. Done in precompilation to avoid runtime performance overhead.
  • Enable make check to check that individual files within folders were also present
  • Added DReyeVRFactory so the EgoVehicle and EgoSensor are spawned with the same "Factory" mechanisms as the other vehicles/sensors, allowing for PythonAPI to spawn the EgoVehicle if it is not in the map. There is a toggle to enable/disable EgoVehicle auto-spawn, else feel free to spawn just like any other Carla vehicle.
  • Improved dash by making the turn signals blink every ~0.4s and fixed a bug with the ToggleReverse function sometimes messing up (especially in replay)
  • Fixed bugs and inconsistencies with replayer media control and special actions such as toggling reverse/turn signals in replay.
  • Moved all blueprint content out of the Carla content (which is now entirely untouched) and to a separate /Game/Content/DReyeVR/ repository (renamed to potentially support future EgoVehicles of different models)
  • Improve SRanipal situation, link to specific (known supported) versions. Includes workaround to avoid SRanipal patch.
  • Create CHANGELOG.md
  • Label release as DReyeVR 0.1.0
@GustavoSilvera GustavoSilvera added the enhancement New feature or request label Jan 8, 2023
@GustavoSilvera GustavoSilvera self-assigned this Jan 8, 2023
@GustavoSilvera GustavoSilvera marked this pull request as draft January 11, 2023 05:39
@GustavoSilvera GustavoSilvera marked this pull request as ready for review February 13, 2023 01:21
@GustavoSilvera GustavoSilvera changed the title [WIP] Improve general functionality and usability Feb 13, 2023
@GustavoSilvera
Copy link
Collaborator Author

Be sure to check out the CHANGELOG.md to get a good summary of what is changed in this version

Copy link
Contributor

@ajdroid ajdroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging based on the code review session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
2 participants