Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Action to use node 16 instead of node 12 #61

Closed
ericcornelissen opened this issue Sep 26, 2022 · 1 comment · Fixed by #68
Closed

Upgrade Action to use node 16 instead of node 12 #61

ericcornelissen opened this issue Sep 26, 2022 · 1 comment · Fixed by #68
Labels
bug Something isn't working

Comments

@ericcornelissen
Copy link

ericcornelissen commented Sep 26, 2022

Following the recent blog post "GitHub Actions: All Actions will begin running on Node16 instead of Node12" by GitHub, I noticed this action is still running on node12:

npm-publish/action.yml

Lines 58 to 60 in e42e372

runs:
using: node12
main: dist/index.js

It should be fairly easy to change this by replacing using: node12 with using: node16 - I wouldn't expect anything in this Action's source code to break as a result of that.

One thing to note, by and large I've seen other Actions use a major version bump when releasing this change. The motivation being that older GitHub Actions runners may not support node16. See for example the "What's new" section of actions/checkout.

@razor-x
Copy link
Collaborator

razor-x commented Jan 2, 2023

I've opened a PR with this update: #68.

@mcous mcous added the bug Something isn't working label Apr 7, 2023
@mcous mcous closed this as completed in #68 Apr 8, 2023
mcous added a commit that referenced this issue Apr 8, 2023
Fixes #61, fixes #67

Co-authored-by: Michael Cousins <michael.cousins@viam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
3 participants