Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodeBugger added some disclaimer on the pip install and added a new notebook with big copypasta no need to install #546

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

furlat
Copy link
Contributor

@furlat furlat commented Jan 8, 2023

Like title, should help up people using it:
CodeBugger added some disclaimer on the pip install and added a new notebook with big copypasta no need to install

@yk
Copy link
Collaborator

yk commented Jan 9, 2023

for the copypasta code, if I understand correctly, that's just the openbugger source code pasted into a notebook? wouldn't it make more sense to actually check in the library, for example at openassistant/utils/ or under scripts/ somewhere? your notebook could then import that, and you could retain an MIT header to indicate that it originally comes from your third-party library.

@furlat
Copy link
Contributor Author

furlat commented Jan 9, 2023

I totally can do it that way! I just wanted to unlock #460, author there should be able to run so no urgency, I will add a few checks and tests and then commit where you thinks is more suitable ad the end of the week (Monday is here T_T )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants