-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Module] Create module for quest workarounds #5831
base: base
Are you sure you want to change the base?
Conversation
Would the right thing to do here be to give Bastok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround, not a fix
Yes, that would be the correct fix. |
Here is my current sqlite db for the weather reporter, there should be enough information in there to get you started, plus the query in the SS above. zone.cpp explains in great detail how to set up weather information for zones: /*************************************************************************
* *
* Loads weather for the zone from zone_bweather SQL Table *
* *
* Weather is a rotating pattern of 2160 vanadiel days for each zone. *
* It's stored as a blob of 2160 16-bit values, each representing 1 day *
* starting from day 0 and storing 3 5-bit weather values each. *
* *
* 0 00000 00000 00000 *
* ^ ^^^^^ ^^^^^ ^^^^^ *
* padding normal common rare *
* *
*************************************************************************/
void CZone::LoadZoneWeather()
{
TracyZoneScoped;
static const char* Query = "SELECT weather FROM zone_weather WHERE zone = %u";
|
Reason I won't accept this (as I explained once in a stream) is that if this goes in, it'll never be properly fixed because it's so small an innocuous. All the information to do it properly is available. |
That's fair. |
If you're not able to do the weather data breakdown, you can change this PR to provide a 'workarounds' Lua module that changes this condition using xi.module.modifyInteractionEntry, which will be off by default. |
In that module, you can provide the steps needed to remedy and get rid of the workaround |
7d66e22
to
186b6fc
Compare
@zach2good - tested this out good to go. Reverted the original file back to what it is currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there
186b6fc
to
de56e67
Compare
de56e67
to
a04a8fe
Compare
a04a8fe
to
d032f08
Compare
370d508
to
27a469f
Compare
[Module] Create module for quest workarounds [Module] Create module for quest workarounds [Module]Create module for quest workarounds [Module]Quest Workarounds [Quest]Work around fix weather [Quest]Fix weather for wish upon star [Module]Create module for quest workarounds Co-Authored-By: Tracent <92269743+TracentEden@users.noreply.github.com> Co-Authored-By: Abdiah <62350957+dallano@users.noreply.github.com>
27a469f
to
cbcd63b
Compare
I affirm:
What does this pull request do?
Allows players to complete the quest Wish Upon a Star. Currently, Bastok does not have a "NONE" weather and therefore will never take the fallen star item. Adding sunshine (clear) remediates this.
Adds an or player:getWeather() == xi.weather.SUNSHINE
Steps to test these changes
Run through the quest players will now be able to complete the quest.